Test suite improvements #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the other tests to still run even if you haven't cloned testdata.
You can now say "make check" to run the tests locally.
Previously it would get stuck in a loop if it encountered EOF in the middle of a string.
atsampson
added
enhancement
ld-decode-tools
happycube
approved these changes
May 28, 2022
simoninns
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes to the test suite:
make check.testdataisn't available.testoutdirectory.JsonReader, and fix a couple of bugs they revealed.It would be nice to have the CI run the tests both for Qt 5 and for Qt 6, but I'm not sure all the Qt 6 deps are available...